Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write docs for discrete module #14994

Merged
merged 3 commits into from Aug 2, 2018

Conversation

Projects
None yet
5 participants
@sidhantnagpal
Copy link
Member

sidhantnagpal commented Jul 30, 2018

Brief description of what is fixed or changed

  • Add discrete.rst in sympy/doc/src/modules for sympy.discrete module
  • Minor documentation improvements

Other comments

Release Notes

NO ENTRY

@sympy-bot

This comment has been minimized.

Copy link

sympy-bot commented Jul 30, 2018

Hi, I am the SymPy bot (v123). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

#### Brief description of what is fixed or changed
- Add `discrete.rst` in `sympy/doc/src/modules` for `sympy.discrete` module
- Minor documentation improvements

#### Other comments


#### Release Notes
<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.


Since the discrete transforms can be used to reduce the computational complexity
of discrete convolutions, therefore, convolutions module makes use of transforms
module for efficienct computation (notable for long input sequences).

This comment has been minimized.

@jksuom

jksuom Jul 30, 2018

Member

efficienct -> efficient

.. automodule:: sympy.discrete

Since the discrete transforms can be used to reduce the computational complexity
of discrete convolutions, therefore, convolutions module makes use of transforms

This comment has been minimized.

@asmeurer

asmeurer Aug 1, 2018

Member

Remove "therefore" (it is redundant with "since"), add "the", and make convolutions code to differentiate it from the previous word, like "convolutions, the convolutions module makes use..."

This comment has been minimized.

@asmeurer

asmeurer Aug 1, 2018

Member

"the transforms module"

^^^^^^^^^^^

This is a general method for calculating the convolution of discrete
sequences, which internally calls one of the methods - ``convolution_fft``,

This comment has been minimized.

@asmeurer

asmeurer Aug 1, 2018

Member

Remove the -


This is a general method for calculating the convolution of discrete
sequences, which internally calls one of the methods - ``convolution_fft``,
``convolution_ntt``, ``convolution_fwht``, ``convolution_subset``.

This comment has been minimized.

@asmeurer

asmeurer Aug 1, 2018

Member

"convolution_fwht, or convolution_subset."

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Aug 1, 2018

Those are all my comments

@jksuom

This comment has been minimized.

Copy link
Member

jksuom commented Aug 2, 2018

Thanks, this seems ready to be merged.

@jksuom jksuom merged commit b7c5ba2 into sympy:master Aug 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.