Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depreciation warnings for bounded/unbounded, infinitesimal #15911

Closed
wants to merge 1 commit into from

Conversation

divyanshu132
Copy link
Member

References to other Issues or PRs

Fixes #15900 #8071

Brief description of what is fixed or changed

Removed the warnings for bounded, unbounded and infinitesimal.

Other comments

Release Notes

  • core
    • remove depreciation warnings

@sympy-bot
Copy link

Hi, I am the SymPy bot (v136). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #15900 #8071
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Removed the warnings for bounded, unbounded and infinitesimal.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
*  core
   *  remove depreciation warnings
<!-- END RELEASE NOTES -->

@divyanshu132
Copy link
Member Author

divyanshu132 commented Feb 3, 2019

@oscargus I'm not able to find if there is any particular test case written specifically for depreciation warnings in sympy/core/tests/test_symbol.py. Can you please point to any test case if it is there??

@oscargus
Copy link
Contributor

oscargus commented Feb 3, 2019

If you look at the test runs (click "Details") and then check the log of the failing tests. Towards the end it says what happened.

For example, for https://travis-ci.org/sympy/sympy/jobs/488134163 it reads

________ sympy/core/tests/test_assumptions.py:test_sanitize_assumptions ________
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/sympy-1.4.dev0-py2.7.egg/sympy/utilities/runtests.py", line 1306, in _timeout
    function()
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/sympy-1.4.dev0-py2.7.egg/sympy/core/tests/test_assumptions.py", line 885, in test_sanitize_assumptions
    assert x.is_real is True
AssertionError

So this seems to be a test explicitly for testing the conversion (which doesn't happen anymore).

Also, in https://travis-ci.org/sympy/sympy/jobs/488134169

 sympy/printing/tests/test_repr.py:test_Symbol_no_special_commutative_treatment 
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/sympy-1.4.dev0-py3.5.egg/sympy/utilities/runtests.py", line 1306, in _timeout
    function()
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/sympy-1.4.dev0-py3.5.egg/sympy/printing/tests/test_repr.py", line 151, in test_Symbol_no_special_commutative_treatment
    sT(Symbol('x', commutative=0), "Symbol('x', commutative=False)")
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/sympy-1.4.dev0-py3.5.egg/sympy/printing/tests/test_repr.py", line 27, in sT
    assert srepr(expr) == string
AssertionError

seems to indicate that the testing tests that 0 is converted to False, while

________ sympy/printing/tests/test_repr.py:test_Symbol_two_assumptions _________
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/sympy-1.4.dev0-py3.5.egg/sympy/utilities/runtests.py", line 1306, in _timeout
    function()
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/sympy-1.4.dev0-py3.5.egg/sympy/printing/tests/test_repr.py", line 144, in test_Symbol_two_assumptions
    assert srepr(x) in (s1, s2)
AssertionError

is not so obvious based on the error log.

Note that there may be more tests in the same function that will fail, if the failing one is edited. Only the first failure in each function is shown.

@Abdullahjavednesar Abdullahjavednesar added the PR: author's turn The PR has been reviewed and the author needs to submit more changes. label Feb 5, 2019
@divyanshu132 divyanshu132 deleted the fix_depreciation branch May 29, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core PR: author's turn The PR has been reviewed and the author needs to submit more changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants