remove tests of deprecated compile_rule #1653

Merged
merged 7 commits into from Nov 20, 2012

3 participants

@smichr
SymPy member

The testing of the deprecated function emits warnings during testing, so tests for it were removed.

@jrioux
SymPy member

Maybe you could add the test for sympify of C & Q where you pass the symbols and it does the correct thing?

@smichr
SymPy member

I added more to the docstring for sympify and added tests showing what you suggested, @jrioux .

@jrioux
SymPy member

SymPy Bot Summary: 🔴 Failed after merging smichr/deprec (6e34489cd856e88805a3e05893fdd0b953818626) into master (6f4dd72).
@smichr: Please fix the test failures.
✳️ PyPy 1.9.1-dev-0; 2.7.3-final-42: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 3.2.1-final-0: pass
🔴 Sphinx 1.1.3: fail

@smichr
SymPy member

I now get a clean sphinx run here. And I added the clashing symbols dictionaries back to abc. You get a lot of garbage if you do exec 'from sympy.abc import *' in {}. These dictionaries are self-updating for any changes that happen to the namespace, so any routine that uses them will always be guaranteed to get the symbols (defined in abc) rather than other sympy objects if they use sympify(foo, locals=_clash).

@smichr
SymPy member

I would love to add the tests for the _clash* dictionary use but it fails in a very odd way. Why should all those tests fail because of an import from abc? @rlamy , @asmeurer -- any ideas?

@jrioux
SymPy member

SymPy Bot Summary: ✳️ Passed after merging smichr/deprec (1c1019a) into master (6f4dd72).
✳️ PyPy 1.9.1-dev-0; 2.7.3-final-42: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 3.2.1-final-0: pass
✳️ Sphinx 1.1.3: pass

@jrioux
SymPy member

SymPy Bot Summary: 🔴 Failed after merging smichr/deprec (7e7fd51d71732f0ddaa845abf36c8c16991dd5af) into master (6f4dd72).
@smichr: Please fix the test failures.
🔴 PyPy 1.9.1-dev-0; 2.7.3-final-42: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
✳️ Sphinx 1.1.3: pass

smichr added some commits Nov 15, 2012
@smichr
SymPy member

OK, I left the commit working around the gamma issue and put a reference to the discussion about it. Is this good to go, @jrioux ?

@smichr smichr merged commit a9aca84 into sympy:master Nov 20, 2012

1 check passed

Details default The Travis build passed
@jrioux
SymPy member

SymPy Bot Summary: ✳️ Passed after merging smichr/deprec (f3aabc5) into master (211f0f7).
✳️ Python 2.7.2-final-0: pass
✳️ Python 3.2.1-final-0: pass
✳️ Sphinx 1.1.3: pass

@coveralls

Coverage Status

Changes Unknown when pulling f3aabc5 on smichr:deprec into ** on sympy:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment