Refactor the testing for "def test_" in test files. #1655

merged 2 commits into from Nov 16, 2012


None yet
3 participants

jrioux commented Nov 14, 2012

Currently, for files matching test_*.py, each lines are first tested for the proper def test_, and then the file isn't rewinded before each lines are tested again for all the remaining code quality issues. Here I refactor the test so that the def test_ test and all the other code quality tests are done in one go through the file.


smichr commented Nov 14, 2012

Thanks! +1


jrioux commented Nov 14, 2012

SymPy Bot Summary: ✳️ Passed after merging jrioux/tests (4e003bb) into master (1abba52).
✳️ PyPy 1.9.1-dev-0; 2.7.3-final-42: pass
✳️ Python 2.7.2-final-0: pass
✳️ Python 3.2.1-final-0: pass
✳️ Sphinx 1.1.3: pass
Docs build command: make html-errors && make clean && make latex && cd _build/latex && xelatex sympy-*.tex


vperic commented Nov 14, 2012

Looks good, assuming the regex is good (I think it is, but my regex-foo is not that good).

smichr added a commit that referenced this pull request Nov 16, 2012

Merge pull request #1655 from jrioux/tests
Refactor the testing for "def test_" in test files.

@smichr smichr merged commit 9e45cba into sympy:master Nov 16, 2012

1 check passed

default The Travis build passed

smichr commented Nov 16, 2012

Thanks, it's in. Could you look over #1653 and perhaps shed some light on the problem that is occurring there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment