Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multinomial, NegativeMultinomial Distribution #16808

Merged
merged 3 commits into from May 12, 2019

Conversation

Projects
None yet
5 participants
@czgdp1807
Copy link
Member

commented May 11, 2019

References to other Issues or PRs

Extends #16576
Don't close any of the two PRs.

Brief description of what is fixed or changed

Multinomial Distribution has been added to
sympy.stats.joint_rv_types. There are import
issues remaining to be resolved.

Other comments

N/A

Release Notes

  • stats
    • Addition of Multinomial Distribution to sympy.stats.joint_rv_types
Added Multinomial Distribution
Multinomial Distribution has been added to
sympy.stats.joint_rv_types. There are import
issues remaining to be resolved.
@sympy-bot

This comment has been minimized.

Copy link

commented May 11, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • stats
    • Addition of Multinomial Distribution to sympy.stats.joint_rv_types (#16808 by @czgdp1807)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Extends https://github.com/sympy/sympy/pull/16576/
Don't close any of the two PRs.

#### Brief description of what is fixed or changed
Multinomial Distribution has been added to
sympy.stats.joint_rv_types. There are import
issues remaining to be resolved.

#### Other comments
N/A

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
  * Addition of Multinomial Distribution to `sympy.stats.joint_rv_types`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #16808 into master will increase coverage by 0.008%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #16808       +/-   ##
=============================================
+ Coverage   73.844%   73.852%   +0.008%     
=============================================
  Files          619       619               
  Lines       159617    159652       +35     
  Branches     37463     37471        +8     
=============================================
+ Hits        117868    117907       +39     
+ Misses       36289     36282        -7     
- Partials      5460      5463        +3

@czgdp1807 czgdp1807 changed the title [WIP][GSoC] Added Multinomial Distribution [GSoC] Added Multinomial, NegativeMultinomial Distribution May 11, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@Upabjojr @sidhantnagpal Please review this PR.

@czgdp1807 czgdp1807 changed the title [GSoC] Added Multinomial, NegativeMultinomial Distribution Added Multinomial, NegativeMultinomial Distribution May 12, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

@sylee957 This PR belongs to stats module. Please update the labels.

@Upabjojr Upabjojr merged commit be5a472 into sympy:master May 12, 2019

3 checks passed

codecov/project 73.852% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.