Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the accessibility of docstrings from Sphinx documentation #16809

Merged
merged 4 commits into from May 12, 2019

Conversation

Projects
None yet
4 participants
@divyanshu132
Copy link
Member

commented May 11, 2019

Brief description of what is fixed or changed

Improved the accessibility of docstrings from Sphinx documentation for modules named:
ntheory
discrete &
assumptions.

Other comments

Release Notes

NO ENTRY

@sympy-bot

This comment has been minimized.

Copy link

commented May 11, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Improved the accessibility of docstrings from Sphinx documentation for modules named:
ntheory
discrete &
assumptions.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #16809 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #16809       +/-   ##
=============================================
- Coverage   73.844%   73.833%   -0.011%     
=============================================
  Files          619       619               
  Lines       159617    159617               
  Branches     37463     37463               
=============================================
- Hits        117868    117851       -17     
- Misses       36289     36305       +16     
- Partials      5460      5461        +1
Linear Recurrences
^^^^^^^^^^^^^^^^^^

.. autofunction:: linrec

This comment has been minimized.

Copy link
@sidhantnagpal

sidhantnagpal May 11, 2019

Member

This could be excluded for now, it should have a user-facing method before making it public.

This comment has been minimized.

Copy link
@divyanshu132

divyanshu132 May 12, 2019

Author Member

Removed it, have a look!

@smichr smichr merged commit 0a6327a into sympy:master May 12, 2019

3 checks passed

codecov/project 73.833% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@divyanshu132 divyanshu132 deleted the divyanshu132:fix-sphinx branch May 12, 2019

@divyanshu132

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

Thanks, @smichr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.