Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Generalized Multivariate Log Gamma Distribution #16825

Merged
merged 20 commits into from May 25, 2019

Conversation

Projects
None yet
7 participants
@czgdp1807
Copy link
Member

commented May 13, 2019

References to other Issues or PRs

Extends #16576

Brief description of what is fixed or changed

Generalized Multivariate Log Gamma Distribution has been added.

Other comments

N/A

Release Notes

  • stats
    • Generalized Multivariate Log Gamma Distribution has been added to sympy.stats.joint_rv_types
@sympy-bot

This comment has been minimized.

Copy link

commented May 13, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • stats
    • Generalized Multivariate Log Gamma Distribution has been added to sympy.stats.joint_rv_types (#16825 by @czgdp1807)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Extends https://github.com/sympy/sympy/pull/16576

#### Brief description of what is fixed or changed
Generalized Multivariate Log Gamma Distribution has been added.

#### Other comments
N/A

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
  * Generalized Multivariate Log Gamma Distribution has been added to `sympy.stats.joint_rv_types`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@czgdp1807 czgdp1807 changed the title Multivar part3 [GSoC] Added Generalized Multivariate Log Gamma Distribution May 13, 2019

czgdp1807 added some commits May 13, 2019

@czgdp1807 czgdp1807 changed the title [GSoC] Added Generalized Multivariate Log Gamma Distribution Added Generalized Multivariate Log Gamma Distribution May 14, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@Upabjojr @sidhantnagpal Please review this PR. This is the last distribution which I wanted to add according to my plan.

czgdp1807 added some commits May 15, 2019

@codecov

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #16825 into master will increase coverage by 0.009%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #16825       +/-   ##
=============================================
+ Coverage   73.888%   73.897%   +0.009%     
=============================================
  Files          619       619               
  Lines       159818    159934      +116     
  Branches     37519     37548       +29     
=============================================
+ Hits        118087    118188      +101     
+ Misses       36266     36261        -5     
- Partials      5465      5485       +20
@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

@Abdullahjavednesar @sylee957 I have made the changes, so I please remove PR:author's turn label.

Show resolved Hide resolved sympy/stats/joint_rv_types.py Outdated
Show resolved Hide resolved sympy/stats/joint_rv_types.py Outdated

@czgdp1807 czgdp1807 force-pushed the czgdp1807:multivar_part3 branch from f8b6b06 to 6ffac25 May 20, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

Show resolved Hide resolved sympy/stats/joint_rv_types.py Outdated

czgdp1807 added some commits May 21, 2019

Show resolved Hide resolved sympy/stats/tests/test_joint_rv.py Outdated
Show resolved Hide resolved sympy/core/tests/test_args.py Outdated
Show resolved Hide resolved sympy/stats/joint_rv_types.py Outdated
Show resolved Hide resolved sympy/stats/joint_rv_types.py Outdated

czgdp1807 and others added some commits May 23, 2019

Update sympy/stats/joint_rv_types.py
Co-Authored-By: Christopher Smith <smichr@gmail.com>

@Upabjojr Upabjojr merged commit 30f47d6 into sympy:master May 25, 2019

3 checks passed

codecov/project 73.897% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@czgdp1807 czgdp1807 deleted the czgdp1807:multivar_part3 branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.