Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gitignore to avoid tracking of vscode's settings.json #16899

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
3 participants
@czgdp1807
Copy link
Member

commented May 26, 2019

References to other Issues or PRs

N/A

Brief description of what is fixed or changed

N/A

Other comments

I recently installed VSCode on my system and observed that as soon as .vscode is created it is being shown in Untracked Files. I believe that such settings files and folders should be in .gitignore file otherwise it makes it to difficult to keep track of the files to commit. Moreover, .vscode can safely be ignored as it is of very little use to the dev community.
If I am wrong then please give a short explanation in the comments section.

Release Notes

NO ENTRY

@sympy-bot

This comment has been minimized.

Copy link

commented May 26, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
N/A

#### Brief description of what is fixed or changed
N/A

#### Other comments
I recently installed VSCode on my system and observed that as soon as `.vscode` is created it is being shown in `Untracked Files`. I believe that such settings files and folders should be in `.gitignore` file otherwise it makes it to difficult to keep track of the files to commit. Moreover, `.vscode` can safely be ignored as it is of very little use to the dev community.
If I am wrong then please give a short explanation in the comments section.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #16899 into master will decrease coverage by 0.004%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #16899       +/-   ##
=============================================
- Coverage   73.891%   73.887%   -0.005%     
=============================================
  Files          619       619               
  Lines       160001    160001               
  Branches     37554     37554               
=============================================
- Hits        118227    118220        -7     
  Misses       36300     36300               
- Partials      5474      5481        +7
@oscarbenjamin

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

Looks good. Thanks!

@oscarbenjamin oscarbenjamin merged commit 5158ecf into sympy:master May 26, 2019

3 checks passed

codecov/project 73.887% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.