Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Removed unreachable code from sympy.stats.frv #16913

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
4 participants
@czgdp1807
Copy link
Member

commented May 28, 2019

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot

This comment has been minimized.

Copy link

commented May 28, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->

#### Brief description of what is fixed or changed

#### Other comments

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@sidhantnagpal

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Seems to have got included in fd827a3, while making RandomSymbol inherit from Expr, not Symbol.

@codecov

This comment has been minimized.

Copy link

commented May 28, 2019

Codecov Report

Merging #16913 into master will increase coverage by 0.019%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #16913       +/-   ##
=============================================
+ Coverage   73.907%   73.926%   +0.019%     
=============================================
  Files          620       620               
  Lines       160204    160203        -1     
  Branches     37599     37599               
=============================================
+ Hits        118403    118433       +30     
+ Misses       36319     36281       -38     
- Partials      5482      5489        +7
@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

@sidhantnagpal Tests passing. Please merge it.

@smichr smichr merged commit b9604c5 into sympy:master May 28, 2019

3 checks passed

codecov/project 73.926% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@czgdp1807 czgdp1807 deleted the czgdp1807:frv_bug branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.