Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improved code in Expr.__lt__ and similar functions in Expr #16956
References to other Issues or PRs
Brief description of what is fixed or changed
With this, the Relational expressions evaluate in the certain conditions.
>>> from sympy import * >>> from sympy.abc import x,y,z >>> a = symbols('a', extended_real =True) >>> a > oo # since a can be real or oo both results in False False >>> a < oo a < oo >>> b = symbols('b', extended_positive=False) >>> b > 0 b > 0 >>>
Your release notes are in good order.
Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.
Click here to see the pull request description that was parsed.
The release notes on the wiki have been updated.
I guess this doesn't affect much (assuming the Travis tests pass).
There have been discussions elsewhere about making invalid inequalities like
@@ Coverage Diff @@ ## master #16956 +/- ## ============================================= + Coverage 73.921% 74.398% +0.477% ============================================= Files 620 622 +2 Lines 160369 160867 +498 Branches 37632 37762 +130 ============================================= + Hits 118547 119683 +1136 + Misses 36335 35864 -471 + Partials 5487 5320 -167
referenced this pull request
Jun 10, 2019
Apparently, the code in
In : x = symbols('x', negative=True) In : y = symbols('y', positive=True) In : x < y Out: True In : 2*x < y-1 Out: 2*x < y - 1 In : ((y-1)-2*x).is_extended_nonnegative # returns None
The return shouldn't be
I think the PR is good but there's a bit of finishing to do.