Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gitignore #17003

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
6 participants
@czgdp1807
Copy link
Member

commented Jun 9, 2019

References to other Issues or PRs

Brief description of what is fixed or changed

I have added an update for pyc file.

Other comments

While working, I observed that files of sympy/integrals/__pycache__/meijerint.cpython-36.pyc.140589556619184 are also being added to git. I have updated the gitignore for the same. I don't know the right way to ignore such files but still made an attempt.

Release Notes

NO ENTRY

@sympy-bot

This comment has been minimized.

Copy link

commented Jun 9, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
I have added an update for `pyc` file.

#### Other comments
While working, I observed that files of `sympy/integrals/__pycache__/meijerint.cpython-36.pyc.140589556619184` are also being added to git. I have updated the gitignore for the same. I don't know the right way to ignore such files but still made an attempt.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@czgdp1807 czgdp1807 added the Workflow label Jun 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 9, 2019

Codecov Report

Merging #17003 into master will increase coverage by 0.295%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##            master   #17003       +/-   ##
============================================
+ Coverage   74.065%   74.36%   +0.295%     
============================================
  Files          620      620               
  Lines       160528   160597       +69     
  Branches     37656    37685       +29     
============================================
+ Hits        118896   119421      +525     
+ Misses       36224    35852      -372     
+ Partials      5408     5324       -84
@oscargus

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Should make sense and be OK to merge.

@Upabjojr

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Just wait a few days in case anyone has an objection, given that it's modifying a basic file.

I'd say, let's merge on Wednesday.

@asmeurer

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I don't know what those files are, but really __pycache__ should be in .gitignore

@oscarbenjamin

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Are those files created by something like vscode or are they new to Python 3.8?

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

May be vscode because i dont have python 3.8
Is this the right way to exclude files with such extension?

@oscarbenjamin

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I think it would be better to add __pycache__ rather that *.pyc.*

@oscarbenjamin

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Looks good, thanks.

@oscarbenjamin oscarbenjamin merged commit 3fe71d4 into sympy:master Jun 13, 2019

3 checks passed

codecov/project 74.36% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@czgdp1807 czgdp1807 deleted the czgdp1807:gitignore branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.