Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy print support for identity matrices #17022

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@anpandey
Copy link
Contributor

commented Jun 12, 2019

References to other Issues or PRs

Fixes #17006

Brief description of what is fixed or changed

Adds support to the NumPy printing for printing identity matrices

Other comments

Release Notes

  • printing
    • NumPy printer now handles identity matrices
@sympy-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #17006 

#### Brief description of what is fixed or changed

Adds support to the NumPy printing for printing identity matrices

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
  * NumPy printer now handles identity matrices
<!-- END RELEASE NOTES -->

@oscargus

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Would it be possible to add a plain printing test that does not rely on NumPy? To increase coverage.

@codecov

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #17022 into master will increase coverage by 0.253%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #17022       +/-   ##
=============================================
+ Coverage   74.214%   74.468%   +0.253%     
=============================================
  Files          620       622        +2     
  Lines       160633    161090      +457     
  Branches     37694     37812      +118     
=============================================
+ Hits        119213    119961      +748     
+ Misses       36036     35797      -239     
+ Partials      5384      5332       -52
Show resolved Hide resolved sympy/printing/pycode.py Outdated

anpandey added some commits Jun 15, 2019

Show resolved Hide resolved sympy/printing/tests/test_numpy.py Outdated
Show resolved Hide resolved sympy/printing/pycode.py

@anpandey anpandey changed the title [WIP] NumPy print support for identity matrices NumPy print support for identity matrices Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.