Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cases in NDimArray operations for sparse array #17026

Merged
merged 1 commit into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@kangzhiq
Copy link
Contributor

commented Jun 14, 2019

References to other Issues or PRs

#16941 __div__ and __neg__

Brief description of what is fixed or changed

  • Fixed issue about sparse arrays being cast to list while performing __div__ and __neg__
  • Added cases in __mul__ and __rmul__ for sparse array if multiplying by 0
  • Added test about dividing by 0
  • Added other tests

Other comments

Release Notes

  • tensor
    • Added specific case for sparse array in div, neg and tests
Added cases in Array operations for sparse array
- Added cases in __div__ for sparse array
- Added cases in __neg__ for sparse array
- Added tests for these two cases
- Added test for div by 0
- Added tests for large scale sparse array in tests of
ImmutableNDimArray
@sympy-bot

This comment has been minimized.

Copy link

commented Jun 14, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • tensor
    • Added specific case for sparse array in div, neg and tests (#17026 by @kangzhiq)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
#16941 `__div__`  and `__neg__`

#### Brief description of what is fixed or changed
- Fixed issue about sparse arrays being cast to list while performing `__div__`  and `__neg__`
- Added cases in `__mul__` and `__rmul__` for sparse array if multiplying by 0
- Added test about dividing by 0
- Added other tests
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* tensor
  * Added specific case for sparse array in __div__, __neg__ and tests
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@czgdp1807

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

If possible, please shift all the imports to the top of the file. Refer, #17017 (comment)

@Upabjojr Upabjojr merged commit a9751e4 into sympy:master Jun 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
@kangzhiq

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

please shift all the imports to the top of the file.

Thank you for your advise, but there is a circular import issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.