Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more features to StochasticProcess #17030

Merged
merged 7 commits into from Jun 17, 2019

Conversation

Projects
None yet
3 participants
@czgdp1807
Copy link
Member

commented Jun 14, 2019

References to other Issues or PRs

[1] #16981

Brief description of what is fixed or changed

joint_dsitribution has been added to StochasticProcess. Test coverage has also been increased.

Other comments

More features like, compute_expectation will be added to the StochasticProcess. Provide your suggestions in the comments, if something more can be added. :)

Release Notes

  • stats
    • joint_distribution added to StochasticProcess.
@sympy-bot

This comment has been minimized.

Copy link

commented Jun 14, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
[1] https://github.com/sympy/sympy/pull/16981

#### Brief description of what is fixed or changed
`joint_dsitribution` has been added to `StochasticProcess`. Test coverage has also been increased.

#### Other comments
More features like, `compute_expectation` will be added to the `StochasticProcess`. Provide your suggestions in the comments, if something more can be added. :)

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
  * `joint_distribution` added to `StochasticProcess`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov

This comment has been minimized.

Copy link

commented Jun 15, 2019

Codecov Report

Merging #17030 into master will increase coverage by 0.061%.
The diff coverage is 79.166%.

@@              Coverage Diff              @@
##            master    #17030       +/-   ##
=============================================
+ Coverage   74.361%   74.423%   +0.061%     
=============================================
  Files          622       622               
  Lines       160776    160789       +13     
  Branches     37738     37743        +5     
=============================================
+ Hits        119556    119664      +108     
+ Misses       35892     35814       -78     
+ Partials      5328      5311       -17

czgdp1807 added some commits Jun 16, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

ping @Upabjojr
Brief Summary of changes:

  • Some helper methods have been added to DiscreteMarkovChain for reducing the repeated code for probability and expectation methods in the same class. The helper methods are, _extract_information, _check_trans_probs, _work_out_state_space and _preprocess.

  • joint_distribution has been added to StochasticProcess as it is general for many processes inheriting it. Tests have been added only for more DiscreteMarkovChain. A part of the same method is untested because, for that processes like, BernoulliProcess, RandomWalk have to be implemented.

I will add the mechanism for more types of queries in one more PR so that it's easier for you to review the current diff.
Thanks.

@czgdp1807 czgdp1807 changed the title [WIP] Adding more features to StochasticProcess Adding more features to StochasticProcess Jun 16, 2019

@Upabjojr Upabjojr merged commit 5a08124 into sympy:master Jun 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@czgdp1807 czgdp1807 deleted the czgdp1807:stch_updt branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.