Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added circular ensembles #17304

Merged
merged 5 commits into from Aug 18, 2019

Conversation

@czgdp1807
Copy link
Member

commented Jul 31, 2019

References to other Issues or PRs

Brief description of what is fixed or changed

Circular ensembles have been added.

Other comments

More features will be added, if possible.
@Upabjojr @sidhantnagpal I am facing a problem(well the last option will be to keep it unevaluated) in exactly defining the density, since it is based on Haar measure which is not unique. Please let me know of any thing available in the literature so that I can do some improvements. I am also right now doing some searching on Google.

Release Notes

  • stats
    • Circular ensembles have been added in sympy.stats.
@sympy-bot

This comment has been minimized.

Copy link

commented Jul 31, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • stats

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Circular ensembles have been added.

#### Other comments
More features will be added, if possible.
@Upabjojr @sidhantnagpal I am facing a problem(well the last option will be to keep it unevaluated) in exactly defining the density, since it is based on Haar measure which is not unique. Please let me know of any thing available in the literature so that I can do some improvements. I am also right now doing some searching on Google.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
  * Circular ensembles have been added in `sympy.stats`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #17304 into master will increase coverage by 0.058%.
The diff coverage is 96%.

@@              Coverage Diff              @@
##            master    #17304       +/-   ##
=============================================
+ Coverage   74.689%   74.747%   +0.058%     
=============================================
  Files          631       631               
  Lines       163223    163515      +292     
  Branches     38294     38362       +68     
=============================================
+ Hits        121911    122224      +313     
+ Misses       35974     35943       -31     
- Partials      5338      5348       +10
@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@Upabjojr @sidhantnagpal I am facing a problem(well the last option will be to keep it unevaluated) in exactly defining the density, since it is based on Haar measure which is not unique. Please let me know of any thing available in the literature so that I can do some improvements. I am also right now doing some searching on Google.

@jksuom Any comments on this. I don't know much about Haar measure. What I know is that it is not unique, so how can I define the density of various circular ensembles. Thanks.

czgdp1807 added some commits Aug 10, 2019

@czgdp1807 czgdp1807 force-pushed the czgdp1807:circular_ensembles branch from 3a08246 to 7ff6f73 Aug 12, 2019

@czgdp1807 czgdp1807 changed the title [WIP] Added circular ensembles Added circular ensembles Aug 16, 2019

@czgdp1807

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

@Upabjojr The work is complete on circular ensembles.
Regarding Haar measure, I will open a separate PR in continuation of this one as predicting things on it's implementation will be difficult for now.

@Upabjojr Upabjojr merged commit 28ea72d into sympy:master Aug 18, 2019

3 checks passed

codecov/project 74.747% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.