Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added induced pcgs and exponent-vector #17317

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@divyanshu132
Copy link
Member

commented Aug 1, 2019

Brief description of what is fixed or changed

Added induced pcgs and exponent-vector for polycyclic subgroup.

Other comments

Release Notes

  • combinatorics
    • added methods to compute induced-pcgs and exp vector for pc subgroup
@sympy-bot

This comment has been minimized.

Copy link

commented Aug 1, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • combinatorics
    • added methods to compute induced-pcgs and exp vector for pc subgroup (#17317 by @divyanshu132)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
 Added induced pcgs and exponent-vector for polycyclic subgroup.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
*  combinatorics
   * added methods to compute induced-pcgs and exp vector for pc subgroup
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

Merging #17317 into master will decrease coverage by 7.958%.
The diff coverage is 65.789%.

@@             Coverage Diff              @@
##           master    #17317       +/-   ##
============================================
- Coverage    74.6%   66.642%   -7.959%     
============================================
  Files         626       626               
  Lines      162415    162588      +173     
  Branches    38104     38204      +100     
============================================
- Hits       121162    108352    -12810     
- Misses      35883     48874    +12991     
+ Partials     5370      5362        -8
@divyanshu132

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

ping @jksuom

@jksuom

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

This looks good but the coverage seems to be falling. Maybe there should be more tests.

@jksuom jksuom merged commit b8c3f40 into sympy:master Aug 17, 2019

3 checks passed

codecov/project 66.642% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details

@divyanshu132 divyanshu132 deleted the divyanshu132:add-induced-pcgs branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.