-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Series: Correcting incorrect limit evaluations based on different assumptions of the limit variable #19292
Conversation
of the limit variable
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Please let me know if this is a similar issue: #9252 |
Codecov Report
@@ Coverage Diff @@
## master #19292 +/- ##
=============================================
- Coverage 75.593% 75.573% -0.021%
=============================================
Files 651 651
Lines 169545 169545
Branches 40016 40016
=============================================
- Hits 128165 128131 -34
- Misses 35762 35795 +33
- Partials 5618 5619 +1 |
This looks good. Gruntz's algorithm deals with functions of a continuous variable. |
That looks like a bug. The result should depend on |
Alright. |
Fixes: #8481
Fixes: #9041
Fixes: #14556
Fixes: #16722
Fixes: #17792
Fixes: #18992
Brief description of what is fixed or changed
Incorrect limit evaluation takes place based on different assumptions of the variable in the limit expression.
The assumption
integer = True
is causing these issues.As we know, Gruntz algorithm changes a variable to a dummy with
positive=True
if the variable does not possess that property. We can make it define a dummy, if the limit variable hasinteger=True
property.So, Gruntz algorithm would not need to work with variables having
integer=True
property and thus this issue won’t occur.The rewrite line can come later, after the dummy variable has been substituted.
Now the limit evaluations take place correctly:
Other Comments
Regression Tests have been added.
Release Notes
limitinf() function of gruntz.py
resolving incorrect limit evaluations