-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Series: Fixing incorrect limit evaluations caused due to bug in rewriting #19297
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #19297 +/- ##
=============================================
- Coverage 75.595% 75.585% -0.011%
=============================================
Files 651 651
Lines 169545 169545
Branches 40016 40016
=============================================
- Hits 128168 128151 -17
- Misses 35762 35780 +18
+ Partials 5615 5614 -1 |
sympy/series/tests/test_limits.py
Outdated
@@ -652,10 +652,18 @@ def test_issue_18306(): | |||
assert limit(sin(sqrt(x))/sqrt(sin(x)), x, 0, '+') == 1 | |||
|
|||
|
|||
def test_issue_18378(): | |||
assert limit(log(exp(3*x) + x)/log(exp(x) + x**100), x, oo).doit() == 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doit()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah actually not needed. Will change it asap. Anything else?
Looks good. |
Fixes: #18378
Fixes: #18482
Closes #18947
Brief description of what is fixed or changed
Incorrect limit evaluation takes place because of bug in rewriting.
The function
xreplace()
in therewrite()
function ofgruntz.py
is not substituting properly.As a result, it has been replaced by the
subs()
function which resolves the issue.Other Comments
Regression Tests have been added.
Release Notes
xreplace()
withsubs()
inrewrite() function of gruntz.py
resolving incorrect limit evaluations