[GSoC] Series: Fixing incorrect limit evaluations caused due to bug in rewriting#19297
Merged
jksuom merged 2 commits intosympy:masterfrom May 12, 2020
Merged
[GSoC] Series: Fixing incorrect limit evaluations caused due to bug in rewriting#19297jksuom merged 2 commits intosympy:masterfrom
jksuom merged 2 commits intosympy:masterfrom
Conversation
|
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #19297 +/- ##
=============================================
- Coverage 75.595% 75.585% -0.011%
=============================================
Files 651 651
Lines 169545 169545
Branches 40016 40016
=============================================
- Hits 128168 128151 -17
- Misses 35762 35780 +18
+ Partials 5615 5614 -1 |
jksuom
reviewed
May 12, 2020
sympy/series/tests/test_limits.py
Outdated
|
|
||
|
|
||
| def test_issue_18378(): | ||
| assert limit(log(exp(3*x) + x)/log(exp(x) + x**100), x, oo).doit() == 3 |
Contributor
Author
There was a problem hiding this comment.
Yeah actually not needed. Will change it asap. Anything else?
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18378
Fixes: #18482
Closes #18947
Brief description of what is fixed or changed
Incorrect limit evaluation takes place because of bug in rewriting.
The function
xreplace()in therewrite()function ofgruntz.pyis not substituting properly.As a result, it has been replaced by the
subs()function which resolves the issue.Other Comments
Regression Tests have been added.
Release Notes
xreplace()withsubs()inrewrite() function of gruntz.pyresolving incorrect limit evaluations