Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Corrects the _eval_as_leading_term() method of tan and sec functions #19461

Merged
merged 1 commit into from May 30, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented May 29, 2020

Brief description of what is fixed or changed

This PR corrects the _eval_as_leading_term() method of tan and sec functions.

It also removes the check: if coeff is S.ComplexInfinity added in this PR: #19432, by handling the cases which returned zoo and correcting them.

Release Notes

  • functions
    • Corrects the _eval_as_leading_term() method of tan and sec functions

@sympy-bot
Copy link

sympy-bot commented May 29, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions
    • Corrects the _eval_as_leading_term() method of tan and sec functions (#19461 by @sachin-4099)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

#### Brief description of what is fixed or changed
This PR corrects the `_eval_as_leading_term()` method of `tan` and `sec` functions.

It also removes the check: `if coeff is S.ComplexInfinity` added in this PR: https://github.com/sympy/sympy/pull/19432, by handling the cases which returned `zoo` and correcting them.

#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Corrects the `_eval_as_leading_term()` method of `tan` and `sec` functions
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #19461 into master will increase coverage by 0.008%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19461       +/-   ##
=============================================
+ Coverage   75.655%   75.663%   +0.008%     
=============================================
  Files          652       652               
  Lines       169727    169736        +9     
  Branches     40065     40065               
=============================================
+ Hits        128408    128429       +21     
+ Misses       35708     35703        -5     
+ Partials      5611      5604        -7     

@oscarbenjamin
Copy link
Contributor

oscarbenjamin commented May 29, 2020

The exception handling in limits.py is a lot better. I'm not too familiar on the other parts of the codebase.

@sachin-4099
Copy link
Contributor Author

sachin-4099 commented May 30, 2020

The exception handling in limits.py is a lot better. I'm not too familiar on the other parts of the codebase.

Yeah, wanted a review from you regarding the exception handling part only.

@jksuom
Copy link
Member

jksuom commented May 30, 2020

Looks good.

@jksuom jksuom merged commit aa9c901 into sympy:master May 30, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants