Core: Fixes a minor performance issue

[sachin-4099]

Fixes: #19534

Other Comments

Regression Test has been added.

Release Notes

NO ENTRY

[sympy-bot]

✅

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

• No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #19534 


#### Other Comments
Regression Test has been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

[codecov]

Codecov Report

Merging #19537 into master will decrease coverage by 8.040%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19537       +/-   ##
=============================================
- Coverage   75.665%   67.624%   -8.041%     
=============================================
  Files          654       654               
  Lines       169900    169939       +39     
  Branches     40055     40065       +10     
=============================================
- Hits        128556    114921    -13635     
- Misses       35727     49388    +13661     
- Partials      5617      5630       +13     

[oscarbenjamin]

@zachetienne can you test out this PR to see if it fixes the problem?

[zachetienne]

@zachetienne can you test out this PR to see if it fixes the problem?

Yes, I tried it out while the PR was undergoing the automatic checks. Indeed it fixes the problem, restoring the original performance.

[zachetienne]

Thanks so much @sachin-4099 and @jksuom !

[asmeurer]

Perhaps we should also add something to the benchmarks, if there isn't already.

[oscarbenjamin]

After a significant regression we should add a benchmark to the benchmarks suite:
https://github.com/sympy/sympy_benchmarks