Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Adds cdir parameter to handle series expansions on branch cuts #19555

Merged
merged 9 commits into from Jun 24, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Jun 14, 2020

Fixes: #7216
Fixes: #19586

Brief description of what is fixed or changed

Adds cdir parameter to handle series expansions on branch cuts.
cdir stands for complex direction, and indicates the direction from which the expansion needs to be evaluated.

Other Comments

Regression Tests have been added.

Release Notes

  • functions
    • Adds cdir parameter to handle series expansions on branch cuts

@sympy-bot
Copy link

@sympy-bot sympy-bot commented Jun 14, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #7216
Fixes: #19586 

#### Brief description of what is fixed or changed

Adds `cdir` parameter to handle `series expansions` on `branch cuts`.
`cdir` stands for `complex direction`, and indicates the direction from which the expansion needs to be evaluated.



#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Adds `cdir` parameter to handle `series expansions` on `branch cuts`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

Added functionality for branch points
sympy/core/expr.py Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Jun 22, 2020

Codecov Report

Merging #19555 into master will increase coverage by 8.066%.
The diff coverage is 80.709%.

@@              Coverage Diff              @@
##            master    #19555       +/-   ##
=============================================
+ Coverage   67.624%   75.691%   +8.066%     
=============================================
  Files          654       656        +2     
  Lines       169939    170543      +604     
  Branches     40065     40235      +170     
=============================================
+ Hits        114921    129086    +14165     
+ Misses       49388     35798    -13590     
- Partials      5630      5659       +29     

@sachin-4099 sachin-4099 marked this pull request as ready for review Jun 22, 2020
sympy/core/mul.py Outdated Show resolved Hide resolved
sympy/core/power.py Outdated Show resolved Hide resolved
sympy/core/tests/test_power.py Outdated Show resolved Hide resolved
@jksuom
Copy link
Member

@jksuom jksuom commented Jun 24, 2020

Thanks, I think this is ready to go.

@jksuom jksuom merged commit 63f8f46 into sympy:master Jun 24, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants