Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified API of ParametricRegion class #19580

Merged
merged 2 commits into from Jun 18, 2020
Merged

Conversation

friyaz
Copy link
Member

@friyaz friyaz commented Jun 17, 2020

References to other Issues or PRs

#19320

Brief description of what is fixed or changed

Old API:

Parametricregion((u, v), (u**3, v**2), {u: (0, 1), v: (1, 2)})

New API:

Parametricregion((u**3, v**2), (u, 0, 1), (v, 1, 2))

Also added dimension property to class.

Other comments

Release Notes

  • vector
    • Modified API of ParametricIntegral class

@sympy-bot
Copy link

@sympy-bot sympy-bot commented Jun 17, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • vector

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
#19320 

#### Brief description of what is fixed or changed
Old API:
```python
Parametricregion((u, v), (u**3, v**2), {u: (0, 1), v: (1, 2)})
```
New API:
```python
Parametricregion((u**3, v**2), (u, 0, 1), (v, 1, 2))
```
Also added dimension property to class. 

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* vector
    * Modified API of ParametricIntegral class

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

@codecov codecov bot commented Jun 17, 2020

Codecov Report

Merging #19580 into master will decrease coverage by 0.006%.
The diff coverage is 95.238%.

@@              Coverage Diff              @@
##            master    #19580       +/-   ##
=============================================
- Coverage   75.642%   75.635%   -0.007%     
=============================================
  Files          654       654               
  Lines       169932    169934        +2     
  Branches     40062     40060        -2     
=============================================
- Hits        128540    128530       -10     
- Misses       35775     35784        +9     
- Partials      5617      5620        +3     

@friyaz
Copy link
Member Author

@friyaz friyaz commented Jun 18, 2020

ping @Upabjojr

@Upabjojr Upabjojr merged commit 8229061 into sympy:master Jun 18, 2020
3 checks passed
@friyaz friyaz changed the title Modified API of ParametricIntegral class Modified API of ParametricRegion class Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants