Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Series: Fixes RecursionError and Timeout in limit evaluations

Merged
merged 6 commits into from Jun 28, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Jun 25, 2020

Fixes: #8208
Fixes: #14514
Fixes: #15202
Fixes: #15282
Fixes: #16714

Brief description of what is fixed or changed

Changes have been done in mrv() function of gruntz.py to handle the indeterminant form of 1**oo more accurately.

Some other changes have been done in Add._eval_as_leading_term() to handle cases in a better way, where leading term has to be evaluated using series computation.

Some major changes have been done in the cancel() function of polytools.py to speed up the algorithm.

Other Comments

Regression Tests have been added.

Release Notes

  • series
    • Changes in mrv() function of gruntz.py and cancel() function of polytools.py resolves RecursionError and Timeout in limit evaluations

@sympy-bot
Copy link

sympy-bot commented Jun 25, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • series
    • Changes in mrv() function of gruntz.py and cancel() function of polytools.py resolves RecursionError and Timeout in limit evaluations (#19646 by @sachin-4099)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #8208
Fixes: #14514
Fixes: #15202
Fixes: #15282
Fixes: #16714

#### Brief description of what is fixed or changed

Changes have been done in `mrv()` function of `gruntz.py` to handle the indeterminant form of `1**oo` more accurately.

Some other changes have been done in `Add._eval_as_leading_term()` to handle cases in a better way, where `leading term` has to be evaluated using `series computation`.

Some major changes have been done in the `cancel()` function of `polytools.py` to speed up the algorithm.

#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* series
  * Changes in `mrv()` function of `gruntz.py` and `cancel()` function of `polytools.py` resolves `RecursionError` and `Timeout` in limit evaluations
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #19646 into master will increase coverage by 0.000%.
The diff coverage is 100.000%.

@@            Coverage Diff             @@
##            master    #19646    +/-   ##
==========================================
  Coverage   75.668%   75.668%            
==========================================
  Files          657       658     +1     
  Lines       170689    171250   +561     
  Branches     40262     40422   +160     
==========================================
+ Hits        129158    129583   +425     
- Misses       35872     35997   +125     
- Partials      5659      5670    +11     

@jksuom
Copy link
Member

jksuom commented Jun 28, 2020

Thanks, I think that this is ready to go.

@oscarbenjamin
Copy link
Contributor

oscarbenjamin commented Mar 3, 2021

Two regressions have recently emerged from this PR: #21024 and #21031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment