-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to integrate scalar/vector fields over objects of geometry module #19650
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
vector_integrate function was modified to integrate
5d8727e
to
96b3f39
Compare
Codecov Report
@@ Coverage Diff @@
## master #19650 +/- ##
=============================================
+ Coverage 75.670% 75.678% +0.008%
=============================================
Files 658 658
Lines 170977 171272 +295
Branches 40342 40420 +78
=============================================
+ Hits 129379 129616 +237
- Misses 35931 35989 +58
Partials 5667 5667 |
First thought... I would try to avoid modifying the geometry module. Since Python 3.5 there is the |
… module to parametric region.
This one looks ok. |
References to other Issues or PRs
#19320
Brief description of what is fixed or changed
Other comments
The integral takes place over the boundary of the geometric entity, not over the area or volume enclosed.
Release Notes