Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests #18452 #19660

Merged
merged 3 commits into from Jun 29, 2020
Merged

Added tests #18452 #19660

merged 3 commits into from Jun 29, 2020

Conversation

akhil-dh1
Copy link
Contributor

@akhil-dh1 akhil-dh1 commented Jun 28, 2020

References to other Issues or PRs

Brief description of what is fixed or changed

Added tests for #18452

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Jun 28, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Added tests for #18452 
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #19660 into master will increase coverage by 0.000%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            master    #19660    +/-   ##
==========================================
  Coverage   75.671%   75.672%            
==========================================
  Files          658       658            
  Lines       170997    171250   +253     
  Branches     40350     40422    +72     
==========================================
+ Hits        129396    129589   +193     
- Misses       35935     35990    +55     
- Partials      5666      5671     +5     

@akhil-dh1
Copy link
Contributor Author

akhil-dh1 commented Jun 28, 2020

@sachin-4099 could you please review

assert limit(abs(log(x))**x, x, 0) == 1
assert limit(abs(log(x))**x, x, 0, "+") == 1
Copy link
Contributor

@sachin-4099 sachin-4099 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the dir will be + in this case, so the testcase having dir explicitly specified as + can be removed.

@@ -737,6 +737,10 @@ def test_issue_18378():
def test_issue_18442():
assert limit(tan(x)**(2**(sqrt(pi))), x, oo, dir='-') == Limit(tan(x)**(2**(sqrt(pi))), x, oo, dir='-')

Copy link
Contributor

@sachin-4099 sachin-4099 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintain two line spacing between the testcases.

@smichr
Copy link
Member

smichr commented Jun 28, 2020

Please make the minor changes then squash all work to a single commit, e.g. after making modifications then, while still on this branch do:

git branch bak
git merge master
git diff master > dif
git checkout master
git branch -D added-tests-#18452
git checkout -b added-tests-#18452
git apply dif
git commit 'closes #18452'
git push -f akhil-dh1 added-tests-#18452
git branch -D bak

@akhil-dh1 akhil-dh1 force-pushed the added-tests-#18452 branch 2 times, most recently from dd2dbca to 0902a42 Compare Jun 28, 2020
@@ -738,6 +738,11 @@ def test_issue_18442():
assert limit(tan(x)**(2**(sqrt(pi))), x, oo, dir='-') == Limit(tan(x)**(2**(sqrt(pi))), x, oo, dir='-')


def test_issue_18452():
assert limit(abs(log(x))**x, x, 0, "+") == 1
Copy link
Contributor

@sachin-4099 sachin-4099 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This without + was required.

Copy link
Contributor

@sachin-4099 sachin-4099 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the dir will be + in this case, so the testcase having dir explicitly specified as + can be removed.

As I have mentioned here.

Copy link
Contributor Author

@akhil-dh1 akhil-dh1 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, i see. I will change

Copy link
Contributor

@sachin-4099 sachin-4099 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are same, that's why + is not required. It will be there by default in this case.

Copy link
Contributor Author

@akhil-dh1 akhil-dh1 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected that.

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jun 28, 2020

As @smichr suggested it should be squashed to a single commit. You can connect with me on gitter, if you are facing difficulties squashing it to a single commit.

smichr
smichr approved these changes Jun 28, 2020
Copy link
Member

@smichr smichr left a comment

looks good

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jun 28, 2020

Looks good to me as well. This can be merged @smichr.

@smichr smichr merged commit be44f94 into sympy:master Jun 29, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants