Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Series: Fixes Incorrect limit evaluations

Merged
merged 5 commits into from Jul 3, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Jul 1, 2020

Fixes: #4114
Fixes: #12398
Fixes: #18399

Brief description of what is fixed or changed

Adds e.is_Pow heuristic to limits.py to handle limit evaluations of Pow objects using the help of meromorphic check, or by separately evaluating the limit of base and exponent and then determining the final limit which needs to be evaluated.

Adds some code to limits.py which improves the evaluation of limits having Abs expressions.

Other Comments

Regression Tests have been added.

Release Notes

  • series
    • Adds e.is_Pow heuristic to limits.py to improve the limit evaluations of Pow objects

@sympy-bot
Copy link

sympy-bot commented Jul 1, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • series
    • Adds e.is_Pow heuristic to limits.py to improve the limit evaluations of Pow objects (#19680 by @sachin-4099)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #4114
Fixes: #12398 
Fixes: #18399 

#### Brief description of what is fixed or changed

Adds `e.is_Pow` heuristic to `limits.py` to handle limit evaluations of `Pow` objects using the help of `meromorphic` check, or by separately evaluating the `limit` of `base` and `exponent` and then determining the final `limit` which needs to be evaluated.

Adds some code to `limits.py` which improves the evaluation of limits having `Abs` expressions.


#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* series
  * Adds `e.is_Pow` heuristic to `limits.py` to improve the limit evaluations of `Pow` objects
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

sympy/series/limits.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #19680 into master will increase coverage by 0.043%.
The diff coverage is 90.769%.

@@              Coverage Diff              @@
##            master    #19680       +/-   ##
=============================================
+ Coverage   75.660%   75.704%   +0.043%     
=============================================
  Files          658       658               
  Lines       171250    171285       +35     
  Branches     40422     40439       +17     
=============================================
+ Hits        129569    129670      +101     
+ Misses       36017     35955       -62     
+ Partials      5664      5660        -4     

sympy/series/limits.py Outdated Show resolved Hide resolved
sympy/series/limits.py Outdated Show resolved Hide resolved
sympy/series/limits.py Outdated Show resolved Hide resolved
@jksuom
Copy link
Member

jksuom commented Jul 3, 2020

Thanks, I think that this is ready.

@jksuom jksuom merged commit 206cdc3 into sympy:master Jul 3, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants