Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Fixes limit evaluations involving error functions

Merged
merged 2 commits into from Jul 5, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Jul 3, 2020

Fixes: #8433
Fixes: #10976
Fixes: #11496
Fixes: #13733
Fixes: #13750

Brief description of what is fixed or changed

Rectifies _eval_rewrite_as_tractable method of class erf.

Adds eval method to class _erfs so that _erfs(0) evaluates to 1.

Corrects the _eval_as_leading_term method of class erf.

Other Comments

Regression Tests have been added.

Release Notes

  • functions
    • Rectifies _eval_rewrite_as_tractable method of class erf

@sympy-bot
Copy link

sympy-bot commented Jul 3, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #8433
Fixes: #10976
Fixes: #11496
Fixes: #13733
Fixes: #13750

#### Brief description of what is fixed or changed

Rectifies `_eval_rewrite_as_tractable` method of `class erf`.

Adds `eval` method to `class _erfs` so that `_erfs(0)` evaluates to `1`.

Corrects the `_eval_as_leading_term` method of `class erf`.


#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Rectifies `_eval_rewrite_as_tractable` method of `class erf`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #19697 into master will increase coverage by 16.120%.
The diff coverage is 100.000%.

@@              Coverage Diff               @@
##            master    #19697        +/-   ##
==============================================
+ Coverage   59.598%   75.719%   +16.120%     
==============================================
  Files          658       658                
  Lines       171259    171340        +81     
  Branches     40423     40450        +27     
==============================================
+ Hits        102068    129737     +27669     
+ Misses       63355     35940     -27415     
+ Partials      5836      5663       -173     

@jksuom
Copy link
Member

jksuom commented Jul 5, 2020

Thanks, this looks good. Merging.

@jksuom jksuom merged commit a1073d1 into sympy:master Jul 5, 2020
3 checks passed
skirpichev added a commit to skirpichev/diofant that referenced this issue May 1, 2022
skirpichev added a commit to skirpichev/diofant that referenced this issue May 1, 2022
skirpichev added a commit to skirpichev/diofant that referenced this issue May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment