Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Fixes limit evaluations related to LambertW function #19716

Merged
merged 1 commit into from Jul 8, 2020

Conversation

sachin-4099
Copy link
Contributor

Fixes: #18969

Brief description of what is fixed or changed

Adds _singularities to LambertW function.

Made minor changes to Pow._eval_nseries to have a more general series expansion.

Other Comments

Regression Tests have been added.

Release Notes

  • functions
    • Adds _singularities to LambertW function

@sympy-bot
Copy link

sympy-bot commented Jul 6, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #18969

#### Brief description of what is fixed or changed

Adds `_singularities` to `LambertW` function.

Made minor changes to `Pow._eval_nseries` to have a more general series expansion.


#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Adds `_singularities` to `LambertW` function
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@sachin-4099
Copy link
Contributor Author

Again Github has not updated to reflect the fact that the Travis tests are complete (#19589).

I'm hoping that this comment will cause it to update.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #19716 into master will increase coverage by 0.010%.
The diff coverage is 91.735%.

@@              Coverage Diff              @@
##            master    #19716       +/-   ##
=============================================
+ Coverage   75.693%   75.704%   +0.010%     
=============================================
  Files          658       659        +1     
  Lines       171307    171328       +21     
  Branches     40441     40414       -27     
=============================================
+ Hits        129669    129703       +34     
- Misses       35973     35981        +8     
+ Partials      5665      5644       -21     

@jksuom
Copy link
Member

jksuom commented Jul 8, 2020

Thanks, this looks good.

@jksuom jksuom merged commit c0bfc81 into sympy:master Jul 8, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong limits of LambertW
3 participants