Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for issue 16735 #19730

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Added tests for issue 16735 #19730

merged 2 commits into from
Jul 9, 2020

Conversation

dkodar20
Copy link
Contributor

@dkodar20 dkodar20 commented Jul 9, 2020 •
edited
Loading

References to other Issues or PRs

Fixes #16735

Brief description of what is fixed or changed

Adds tests to concrete/tests/test_sums_products.py and series/tests/test_limitseq.py

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Jul 9, 2020 •
edited
Loading

✅

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #16735

#### Brief description of what is fixed or changed
Adds tests to `concrete/tests/test_sums_products.py` and `series/tests/test_limitseq.py`

#### Other comments


#### Release Notes
<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@dkodar20 dkodar20 changed the title Added tests for issue 16735 Added tests for issue #16735 Jul 9, 2020
@dkodar20 dkodar20 changed the title Added tests for issue #16735 Added tests for issue 16735 Jul 9, 2020
sachin-4099
sachin-4099 reviewed Jul 9, 2020
View reviewed changes
sympy/concrete/tests/test_sums_products.py Outdated
@@ -1317,6 +1317,11 @@ def test_issue_14313():
assert Sum(S.Half**floor(n/2), (n, 1, oo)).is_convergent()


@XFAIL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. This is not a test which fails.

sympy/series/tests/test_limitseq.py Outdated
@@ -125,6 +125,10 @@ def test_issue_10382():
assert limit_seq(fibonacci(n+1)/fibonacci(n), n) == S.GoldenRatio


def test_issue_16735():
assert limit_seq(5**n/factorial(n),n) == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space after comma.

sachin-4099
sachin-4099 reviewed Jul 9, 2020
View reviewed changes
sympy/concrete/tests/test_sums_products.py Outdated
@@ -1317,6 +1317,11 @@ def test_issue_14313():
assert Sum(S.Half**floor(n/2), (n, 1, oo)).is_convergent()


@XFAIL
def test_issue_16735():
assert Sum(5**n/gamma(n+1), (n, 1, oo)).is_convergent() is True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be S.true rather than True.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that S.true issue. When it is True, the test fails and hence I added @XFAIL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes now.

@sachin-4099
Copy link
Contributor

Looks good to me. Once the build passes, this can be merged @jksuom.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #19730 into master will increase coverage by 4.386%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #19730       +/-   ##
=============================================
+ Coverage   71.333%   75.720%   +4.386%     
=============================================
  Files          659       659               
  Lines       171335    171401       +66     
  Branches     40416     40437       +21     
=============================================
+ Hits        122220    129785     +7565     
+ Misses       43300     35967     -7333     
+ Partials      5815      5649      -166

@jksuom
Copy link
Member

jksuom commented Jul 9, 2020

Thanks, looks good.

@jksuom jksuom merged commit fe44a93 into sympy:master Jul 9, 2020
@dkodar20 dkodar20 deleted the 16735_concrete_series branch July 11, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-4099 sachin-4099 sachin-4099 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sum.is_convergent uses the incorrect results from limit_seq
4 participants
@dkodar20 @sympy-bot @sachin-4099 @jksuom