series : Added test for issue 14793#19737
Conversation
|
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed. |
sympy/series/tests/test_limits.py
Outdated
| def test_issue_14793(): | ||
| expr = ((x + S(1)/2) * log(x) - x + log(2*pi)/2 - \ | ||
| log(factorial(x)) + S(1)/(12*x))*x**3 | ||
| assert simplify(limit(expr, x, oo) - 1/360) == 0 |
There was a problem hiding this comment.
This should be assert limit(expr, x, oo) == S(1)/360.
There was a problem hiding this comment.
I see. Are there any particular disadvantages of the way done previously?
There was a problem hiding this comment.
The call to simplify() function is always costly, it should be avoided as much as possible.
There was a problem hiding this comment.
Okay, I will make the required changes.
Codecov Report
@@ Coverage Diff @@
## master #19737 +/- ##
=============================================
+ Coverage 75.709% 75.728% +0.019%
=============================================
Files 659 659
Lines 171401 171401
Branches 40437 40437
=============================================
+ Hits 129766 129799 +33
+ Misses 35982 35959 -23
+ Partials 5653 5643 -10 |
|
Looks good to me. This can be merged @jksuom. |
|
Thanks. |
Added test to series/test_series.py
References to other Issues or PRs
Fixes #14793
Brief description of what is fixed or changed
Added a test in order to close the issue
Other comments
Release Notes
NO ENTRY