Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19766 Fixes incorrect limit #19771

Merged
merged 1 commit into from Jul 16, 2020
Merged

#19766 Fixes incorrect limit #19771

merged 1 commit into from Jul 16, 2020

Conversation

shivangdubey
Copy link
Contributor

@shivangdubey shivangdubey commented Jul 14, 2020

Fixes partially #19766
Added a test case for the limit.
limit(2**(-x)*sqrt(4**(x+1)+1), x, oo)

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Jul 14, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes partially #19766 
Added a test case for the limit.
`limit(2**(-x)*sqrt(4**(x+1)+1), x, oo)`

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

sympy/series/tests/test_limits.py Show resolved Hide resolved
sympy/series/tests/test_limits.py Outdated Show resolved Hide resolved
@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 14, 2020

Add NO ENTRY in release notes,

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 14, 2020

Just squash both the commits into one and add a more suitable commit message.

The travis-build will fail due to this: #19768
When this issue gets resolved we will restart the build and merge this PR.

@shivangdubey
Copy link
Contributor Author

shivangdubey commented Jul 14, 2020

Just squash both the commits into one and add a more suitable commit message.

The travis-build will fail due to this: #19768
When this issue gets resolved we will restart the build and merge this PR.

Alright! The commits have been squashed and pushed.

sympy/core/tests/test_evalf.py Outdated Show resolved Hide resolved
@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 15, 2020

On master:

In [14]: exp(x/2).evalf()
Out[14]:
 x
 -
 2
e

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 16, 2020

I have restarted the build.
@shivangdubey please mention:
Partially Fixes #19766 instead of Fixes #19766.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #19771 into master will decrease coverage by 0.006%.
The diff coverage is 86.666%.

@@              Coverage Diff              @@
##            master    #19771       +/-   ##
=============================================
- Coverage   75.703%   75.696%   -0.007%     
=============================================
  Files          662       662               
  Lines       172162    172167        +5     
  Branches     40604     40605        +1     
=============================================
- Hits        130332    130325        -7     
- Misses       36138     36144        +6     
- Partials      5692      5698        +6     

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 16, 2020

Looks good to me. This can be merged @jksuom.

@jksuom
Copy link
Member

jksuom commented Jul 16, 2020

Thanks.

@jksuom jksuom merged commit 00f4aa1 into sympy:master Jul 16, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants