Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to close 14037 #19805

Merged
merged 2 commits into from Jul 24, 2020
Merged

add test to close 14037 #19805

merged 2 commits into from Jul 24, 2020

Conversation

goddus
Copy link
Contributor

@goddus goddus commented Jul 20, 2020

References to other Issues or PRs

Fixes #14037

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Jul 20, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #14037 



#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #19805 into master will increase coverage by 0.013%.
The diff coverage is 92.857%.

@@              Coverage Diff              @@
##            master    #19805       +/-   ##
=============================================
+ Coverage   75.693%   75.707%   +0.013%     
=============================================
  Files          658       664        +6     
  Lines       171307    172374     +1067     
  Branches     40441     40653      +212     
=============================================
+ Hits        129669    130500      +831     
- Misses       35973     36162      +189     
- Partials      5665      5712       +47     

@Smit-create Smit-create requested a review from sachin-4099 Jul 21, 2020
Copy link
Contributor

@sachin-4099 sachin-4099 left a comment

Just add this testcase as well to series/test_series.py:

In [2]: (sin(x**50)/x**51).series(x, n=0)
Out[2]:
1
- + O(1)
x

@goddus
Copy link
Contributor Author

goddus commented Jul 21, 2020

@sachin-4099 I added the test, however it is causing an assertion error and I can't seem to figure out why. I ran the command on the master and it worked fine, so I was wondering if it could possibly be a syntax issue or something else.

The contents of the test are assert (sin(x**50)/x**51).series(x, n=0) == 1/x + O(1)

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 21, 2020

This will work:
assert (sin(x**50)/x**51).series(x, n=0) == 1/x + O(1, x)

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 24, 2020

Looks good to me. This can be merged @jksuom.

@sachin-4099 sachin-4099 requested a review from jksuom Jul 24, 2020
@jksuom
Copy link
Member

jksuom commented Jul 24, 2020

Thanks.

@jksuom jksuom merged commit 044c6e4 into sympy:master Jul 24, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

residue(sin(x**50)/x**51, x, 0) raises an error
5 participants