Skip to content

add test of issue 11407#19824

Merged
jksuom merged 2 commits into
sympy:masterfrom
1124816:test_issue_11407
Jul 25, 2020
Merged

add test of issue 11407#19824
jksuom merged 2 commits into
sympy:masterfrom
1124816:test_issue_11407

Conversation

@1124816

@1124816 1124816 commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

References to other Issues or PRs

Fixes #11407

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot

Copy link
Copy Markdown

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #11407 

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@codecov

codecov Bot commented Jul 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #19824 into master will increase coverage by 4.588%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #19824       +/-   ##
=============================================
+ Coverage   59.703%   64.292%   +4.588%     
=============================================
  Files          664       664               
  Lines       172479    172479               
  Branches     40678     40678               
=============================================
+ Hits        102976    110891     +7915     
+ Misses       63671     55206     -8465     
- Partials      5832      6382      +550     

@sachin-4099 sachin-4099 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sachin-4099
sachin-4099 requested a review from jksuom July 24, 2020 17:44
@sachin-4099

sachin-4099 commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Due to the recent merges, the branch now has conflicts. Please resolve those after which this can be merged.

@jksuom

jksuom commented Jul 25, 2020

Copy link
Copy Markdown
Member

@1124816 I merged this with the web editor but that left some invisible trailing whitespace.
Can you do the merge locally on the command line (in the same way but with no whitespace) and then push the result with the -f flag?

@1124816
1124816 force-pushed the test_issue_11407 branch from 8fe67a1 to 8ff3e47 Compare July 25, 2020 15:13
@jksuom

jksuom commented Jul 25, 2020

Copy link
Copy Markdown
Member

Thanks, this looks good now.

@jksuom
jksuom merged commit e139b81 into sympy:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Series expansion of the square root gives wrong result

5 participants