-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for limit_seq in series #19876
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
sympy/series/tests/test_limitseq.py
Outdated
# issue 19868 | ||
assert limit_seq(1/gamma(n+S.One/2), n) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be like this:
def test_issue_19868():
assert limit_seq(1/gamma(n + S.One/2), n) == 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also maintain two line spacing between the testcases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks
Fixed format of testcase as guided. Please review |
sympy/series/tests/test_limitseq.py
Outdated
@@ -133,6 +133,10 @@ def test_issue_16735(): | |||
assert limit_seq(5**n/factorial(n), n) == 0 | |||
|
|||
|
|||
def test_issue_19868(): | |||
assert limit_seq(1/gamma(n + S.One/2), n) == 0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line contains trailing whitespaces. Line number 138.
Fixed, thanks |
Add |
Added gamma to imports. Could you please give me guidance on how to squash the commits? |
Done. Please review |
Codecov Report
@@ Coverage Diff @@
## master #19876 +/- ##
=============================================
+ Coverage 75.703% 75.741% +0.038%
=============================================
Files 662 667 +5
Lines 172162 172738 +576
Branches 40604 40720 +116
=============================================
+ Hits 130332 130835 +503
- Misses 36138 36178 +40
- Partials 5692 5725 +33 |
Looks good to me. This can be merged @jksuom. |
Thanks. |
####References to other Issues or PRs
Fixes #19868
Brief description of what is fixed or changed
Added simple test case for limit_seq, to ensure correct output of 0 instead of oo.
Current master gives 0.
Other comments
NA
Release Notes
NO ENTRY