Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Fixes limit evaluations related to trigonometric functions #19916

Merged
merged 3 commits into from Aug 8, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Aug 7, 2020

Fixes: #19770

Brief description of what is fixed or changed

Adds _eval_nseries function to sin and cos.
Adds a piece of code to cos.eval in order to handle the non-zero case.

Other Comments

Regression Tests have been added.

Release Notes

  • functions
    • Adds _eval_nseries function to sin and cos.

@sympy-bot
Copy link

sympy-bot commented Aug 7, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #19770

#### Brief description of what is fixed or changed

Adds `_eval_nseries` function to `sin` and `cos`.
Adds a piece of code to `cos.eval` in order to handle the `non-zero` case.


#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Adds `_eval_nseries` function to `sin` and `cos`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #19916 into master will increase coverage by 0.034%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19916       +/-   ##
=============================================
+ Coverage   75.778%   75.812%   +0.034%     
=============================================
  Files          668       668               
  Lines       173216    173237       +21     
  Branches     40837     40841        +4     
=============================================
+ Hits        131261    131336       +75     
+ Misses       36221     36174       -47     
+ Partials      5734      5727        -7     

@jksuom
Copy link
Member

jksuom commented Aug 8, 2020

Thanks, looks good.

@jksuom jksuom merged commit 1b9a569 into sympy:master Aug 8, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit involving cosine
3 participants