-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test for limit issue #19922
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
sympy/series/tests/test_limits.py
Outdated
|
||
|
||
def test_issue_8229(): | ||
assert limit((x**Rational(1,4)-2)/(sqrt(x)-4)**Rational(2,3), x, 16) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There can be spaces around -
and after ,
inside Rational
.
So something like this:
limit((x**Rational(1, 4) - 2)/(sqrt(x) - 4)**Rational(2, 3), x, 16) == 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Moreover, don't add the testcase to the end of the file. Please find similar numbered issues and add the testcase around that place in the file. |
Codecov Report
@@ Coverage Diff @@
## master #19922 +/- ##
=============================================
- Coverage 75.811% 75.802% -0.010%
=============================================
Files 668 668
Lines 173237 173237
Branches 40841 40841
=============================================
- Hits 131334 131318 -16
- Misses 36172 36184 +12
- Partials 5731 5735 +4 |
Looks good to me. This can be merged @jksuom. |
Thank you, merging. |
References to other Issues or PRs
Fixes #8229
Brief description of what is fixed or changed
Added a regression test for limit issue.
Other comments
Release Notes
NO ENTRY