Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for limit issue #19922

Merged
merged 1 commit into from Aug 10, 2020
Merged

Regression test for limit issue #19922

merged 1 commit into from Aug 10, 2020

Conversation

dsaw
Copy link
Contributor

@dsaw dsaw commented Aug 8, 2020

References to other Issues or PRs

Fixes #8229

Brief description of what is fixed or changed

Added a regression test for limit issue.

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Aug 8, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #8229

#### Brief description of what is fixed or changed
Added a regression test for limit issue.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@dsaw dsaw marked this pull request as ready for review Aug 8, 2020
@dsaw dsaw changed the title Regression test for limit issue #8229 Regression test for limit issue Aug 8, 2020


def test_issue_8229():
assert limit((x**Rational(1,4)-2)/(sqrt(x)-4)**Rational(2,3), x, 16) == 0
Copy link
Contributor

@sachin-4099 sachin-4099 Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be spaces around - and after , inside Rational.
So something like this:
limit((x**Rational(1, 4) - 2)/(sqrt(x) - 4)**Rational(2, 3), x, 16) == 0

Copy link
Contributor Author

@dsaw dsaw Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sachin-4099
Copy link
Contributor

sachin-4099 commented Aug 8, 2020

Moreover, don't add the testcase to the end of the file. Please find similar numbered issues and add the testcase around that place in the file.
Also please squash all these commits into a single commit.

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #19922 into master will decrease coverage by 0.009%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #19922       +/-   ##
=============================================
- Coverage   75.811%   75.802%   -0.010%     
=============================================
  Files          668       668               
  Lines       173237    173237               
  Branches     40841     40841               
=============================================
- Hits        131334    131318       -16     
- Misses       36172     36184       +12     
- Partials      5731      5735        +4     

@sachin-4099
Copy link
Contributor

sachin-4099 commented Aug 10, 2020

Looks good to me. This can be merged @jksuom.

@sachin-4099 sachin-4099 requested a review from jksuom Aug 10, 2020
@jksuom
Copy link
Member

jksuom commented Aug 10, 2020

Thank you, merging.

@jksuom jksuom merged commit 56b315e into sympy:master Aug 10, 2020
3 checks passed
@dsaw dsaw deleted the regtest-8229 branch Aug 10, 2020
@dsaw dsaw restored the regtest-8229 branch Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit((x**Rational(1,4)-2)/(sqrt(x)-4)**Rational(2, 3), x, 16) NotImplementedError
4 participants