-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test case for series expansion of polynomial/rational expression #19974
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
sympy/series/tests/test_series.py
Outdated
beta = symbols('beta', reals=True, positive=True) | ||
theta, varphi = symbols('theta varphi', reals=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be real=True
.
sympy/series/tests/test_series.py
Outdated
/((0.5*cos(theta) - 1)**2*(0.5*cos(theta) - 1.0))) + 0.25*varphi*\ | ||
sin(theta)/(0.5*cos(theta) - 1)**2 + O((beta - 0.5)**2, (beta, 0.5)) | ||
|
||
assert(expr.series(beta, 0.5, 2) == sol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simply:
assert expr.series(beta, 0.5, 2) == sol
(without round brackets).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll make the changes suggested by you.
Moreover, don't simply add the testcase to the end of the file. Please find issue numbers closer to the issue number this PR resolves and add the testcase to that place. |
Codecov Report
@@ Coverage Diff @@
## master #19974 +/- ##
=============================================
+ Coverage 75.814% 75.831% +0.016%
=============================================
Files 669 669
Lines 173463 173463
Branches 40907 40907
=============================================
+ Hits 131510 131539 +29
+ Misses 36230 36202 -28
+ Partials 5723 5722 -1 |
So, can I add that in |
No, not inside that. But closer to that. |
Just below that function. If I am not wrong. |
Yeah should be fine. |
Looks good. This can be merged @jksuom. |
Thanks! for the help @sachin-4099 |
Thank you, this looks good. |
References to other Issues or PRs
#12791
Brief description of what is fixed or changed
Added a test case for the series expansion of polynomial/rational expression in test_series.py
Other comments
Release Notes
NO ENTRY