Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Fixes limit evaluations related to uppergamma and besselk function #19990

Merged
merged 2 commits into from Aug 21, 2020

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Aug 20, 2020

Fixes: #13571
Fixes: #14874

Brief description of what is fixed or changed

  1. Adds _eval_is_meromorphic method and _eval_aseries to class lowergamma
  2. Adds _eval_is_meromorphic method and _eval_rewrite_as_tractable method to class uppergamma
  3. Rectifies eval method of class besselk

Other Comments

Regression Tests have been added.

Release Notes

  • functions
    • Adds _eval_is_meromorphic method and _eval_aseries to class lowergamma
    • Adds _eval_is_meromorphic method and _eval_rewrite_as_tractable method to class uppergamma
    • Rectifies eval method of class besselk

@sympy-bot
Copy link

sympy-bot commented Aug 20, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • functions
    • Adds _eval_is_meromorphic method and _eval_aseries to class lowergamma (#19990 by @sachin-4099)

    • Adds _eval_is_meromorphic method and _eval_rewrite_as_tractable method to class uppergamma (#19990 by @sachin-4099)

    • Rectifies eval method of class besselk (#19990 by @sachin-4099)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #13571 
Fixes: #14874 

#### Brief description of what is fixed or changed

  1) Adds `_eval_is_meromorphic` method and  `_eval_aseries` to `class lowergamma` 
  2) Adds  `_eval_is_meromorphic` method and `_eval_rewrite_as_tractable` method to `class uppergamma`
  3) Rectifies `eval` method of `class besselk`


#### Other Comments
Regression Tests have been added.


#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Adds `_eval_is_meromorphic` method and  `_eval_aseries` to `class lowergamma` 
  * Adds  `_eval_is_meromorphic` method and `_eval_rewrite_as_tractable` method to `class uppergamma`
  * Rectifies `eval` method of `class besselk`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

sympy/functions/special/bessel.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #19990 into master will increase coverage by 0.002%.
The diff coverage is 75.000%.

@@              Coverage Diff              @@
##            master    #19990       +/-   ##
=============================================
+ Coverage   59.579%   59.581%   +0.002%     
=============================================
  Files          669       669               
  Lines       173475    173498       +23     
  Branches     40911     40915        +4     
=============================================
+ Hits        103355    103373       +18     
- Misses       64266     64269        +3     
- Partials      5854      5856        +2     

@jksuom
Copy link
Member

jksuom commented Aug 21, 2020

Thanks, looks good.

@jksuom jksuom merged commit 67044be into sympy:master Aug 21, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit x --> oo for besselk Incorrect limit of uppergamma(n, 1) / gamma(n)
3 participants