Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Functions: Fixes _eval_nseries() of log #20002

Merged
merged 2 commits into from Aug 26, 2020
Merged

Conversation

sachin-4099
Copy link
Contributor

@sachin-4099 sachin-4099 commented Aug 26, 2020

Fixes: #18842

Brief description of what is fixed or changed

Rewrites _eval_nseries method of log present in exponential.py.

Other Comments

Regression Test has been added.

Release Notes

  • functions
    • Fixes _eval_nseries method of log

@sympy-bot
Copy link

sympy-bot commented Aug 26, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes: #18842

#### Brief description of what is fixed or changed
Rewrites `_eval_nseries` method of `log` present in `exponential.py`.

#### Other Comments
Regression Test has been added.

#### Release Notes


<!-- BEGIN RELEASE NOTES -->
* functions
  * Fixes `_eval_nseries` method of `log`
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #20002 into master will increase coverage by 4.461%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #20002       +/-   ##
=============================================
+ Coverage   71.411%   75.872%   +4.461%     
=============================================
  Files          669       669               
  Lines       173512    173546       +34     
  Branches     40956     40966       +10     
=============================================
+ Hits        123907    131674     +7767     
+ Misses       43742     36137     -7605     
+ Partials      5863      5735      -128     

@jksuom
Copy link
Member

jksuom commented Aug 26, 2020

Thanks, I think this is ready to be merged.

@jksuom jksuom merged commit d20fcb2 into sympy:master Aug 26, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with series expansion of expression with log
3 participants