-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of is_nthpow_residue
#25045
Conversation
Prevent `_is_nthpow_residue_bign_prime_power` from calling `_is_nthpow_residue_bign` recursively. Then `_is_nthpow_residue_bign` was removed because it would only be a function to factorize prime and call `_is_nthpow_residue_bign_prime_power`.
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
|
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[2c3de5f4] [877c1421]
- 83.5±0.3ms 54.0±0.3ms 0.65 integrate.TimeIntegrationRisch02.time_doit(10)
- 82.8±0.7ms 52.9±0.3ms 0.64 integrate.TimeIntegrationRisch02.time_doit_risch(10)
Full benchmark results can be found as artifacts in GitHub Actions |
Prevent
_is_nthpow_residue_bign_prime_power
from calling_is_nthpow_residue_bign
recursively. Then_is_nthpow_residue_bign
was removed because it would only be a function to factorize prime and call_is_nthpow_residue_bign_prime_power
.References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes
_is_nthpow_residue_bign