Fix Wigner Issue: float arguments to range() in gaunt(), racah(), wigner_9j() #2878

Merged
merged 1 commit into from Feb 6, 2014

Projects

None yet

3 participants

Contributor

Fix for issue:
#2767

#2767

@smichr smichr commented on the diff Feb 5, 2014
sympy/physics/wigner.py
@@ -384,7 +384,7 @@ def racah(aa, bb, cc, dd, ee, ff, prec=None):
_calc_factlist(maxfact)
sumres = 0
- for kk in range(imin, imax + 1):
+ for kk in range(int(imin), int(imax) + 1):
smichr
smichr Feb 5, 2014 Member

How do we know that the truncated integer is what should be used when imin or imax is a half integer?

Owner
asmeurer commented Feb 6, 2014

I guess here is the same part in wigner3j.

Contributor

What is the meaning of Travis CI build error? I read about it on the internet. Couldn't figure out the exact problem.
Has it got to do anything with my patch?

I'm a newbie. Please help.

Member
smichr commented Feb 6, 2014

don't worry about that error.

Thanks, this is in.

@smichr smichr merged commit e09a1ad into sympy:master Feb 6, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@rajathshashidhara rajathshashidhara deleted the unknown repository branch Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment