fix docstring of is_zero() #2970

Merged
merged 2 commits into from Mar 23, 2014

Projects

None yet

4 participants

@curiousguy13
Contributor

resolves #2969

@smichr smichr commented on an outdated diff Feb 27, 2014
sympy/integrals/integrals.py
@@ -107,7 +107,7 @@ def free_symbols(self):
@property
def is_zero(self):
- """Since Integral doesn't autosimplify it it useful to see if
+ """Since Integral doesn't autosimplify it, it is useful to see if
@smichr
smichr Feb 27, 2014 Member

I think it would read better to leave the first it out...or the second. :-)

@curiousguy13
Contributor

@smichr this is my first pull request here, can you tell me why is the Travis CI build failing?

@skirpichev
Contributor

rebase pr and fixup the last commit:

git chechout master
git pull
git checkout your_branch
git rebase -i master
git push -f github your_branch
@asmeurer asmeurer merged commit 6c506d6 into sympy:master Mar 23, 2014

1 check passed

default The Travis CI build passed
Details
@asmeurer
Member

huh, I guess "resolves" is a valid verb to close an issue.

@asmeurer
Member

And it wasn't even in the commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment