Pull 140-v2: New matrices support in sympy.physics.matrices #515

wants to merge 3 commits into


None yet
6 participants

plaes commented Jul 27, 2011

This is effectively pull request 140 which is rebased and original commits are squashed.

Original is here: #140


smichr commented Jul 27, 2011

The old request can be closed now. (It will still be accessible through the URL you cited above.)


lazovich commented Jul 27, 2011

Test results html report: http://pastehtml.com/view/b1vl2g758.html

Automatic review by sympy-bot.

@lazovich lazovich and 1 other commented on an outdated diff Jul 27, 2011

@@ -1168,11 +1164,9 @@ def test_nonvectorJacobian():
x, y, z = symbols('x y z')
X = Matrix([ [exp(x + y + z), exp(x + y + z)],
[exp(x + y + z), exp(x + y + z)] ])
- Y = Matrix([x, y, z])
- raises(TypeError, 'X.jacobian(Y)')
+ raises(TypeError, 'X.jacobian(Matrix([x, y, z])')

lazovich Jul 27, 2011


Looks like there is a missing paren inside the quotes here. I think it should be

raises(TypeError, 'X.jacobian(Matrix[x y, z]))')


plaes Jul 27, 2011


Uh-oh.. I pushed this patch from wrong machine (I had this issue fixed on my laptop, but I ran tests on my desktop machine, and this is where I fixed it) :S

Fixed now..


lazovich commented Jul 28, 2011

Test results html report: http://pastehtml.com/view/b1wjwwir0.html

Automatic review by sympy-bot.


lazovich commented Jul 28, 2011

@plaes: All tests pass now, thanks!

This looks good to me, and I think it was pretty thoroughly reviewed in the last PR, so I am +1 on getting it merged.


asmeurer commented Aug 11, 2011

Test results html report: http://pastehtml.com/view/b3ik6bni5.html

Summary: There do not appear to be any problems.

Please double check this against the test report given above before merging with master.

Automatic review by sympy-bot.


plaes commented Aug 27, 2011

I rebased and fixed new doctest issues 3**(1/2) vs sqrt(3).


certik commented Oct 12, 2011

I have rebased, fixed a few test failures and pushed it in. Thanks!

certik closed this Oct 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment