New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign Error in Unrad Function issue #8622 … #8647

Merged
merged 1 commit into from Dec 23, 2014

Conversation

Projects
None yet
2 participants
@aktech
Copy link
Member

aktech commented Dec 18, 2014

Example:

unrad((root(x + 1, 5) - root(x, 3))) should return (x**5 - x**3 - 3*x**2 - 3*x - 1, [], [])
but earlier it was returning (x**5 + x**3 + 3*x**2 + 3*x + 1, [], [])

This Pull Request Fixes #8622 & also adds Tests for this.
as pointed out by @smichr

@smichr Please have a look.

Thanks

@aktech

This comment has been minimized.

Copy link
Member Author

aktech commented Dec 19, 2014

This fixes #8622

@aktech aktech changed the title Solves sign Error in Unrad Function issue #8622 … Fix sign Error in Unrad Function issue #8622 … Dec 20, 2014

@smichr

This comment has been minimized.

Copy link
Member

smichr commented Dec 21, 2014

Ok, looks pretty good. Can you squash this down to 1 commit?

And then in your last comment above, remove the word "issue" from between "fixes" and the "#" so the issue automatically gets closed when this is committed.

Thanks

Sign Error in Unrad Function issue #8622
Added Test for SIgn Error in unrad

	assert unrad((root(x + 1, 5) - root(x, 3))) == (x**5 - x**3 - 3*x**2 - 3*x - 1, [], [])

Added Test for SIgn Error in unrad issue #8622

Added Test for issue #8622
assert unrad((root(x + 1, 5) - root(x, 3))) == (x**5 - x**3 - 3*x**2 - 3*x - 1, [], [])

@aktech aktech force-pushed the aktech:master branch from 89a108c to a189bd7 Dec 21, 2014

@aktech

This comment has been minimized.

Copy link
Member Author

aktech commented Dec 21, 2014

@smichr
I have squashed the commits down to 1.

Thanks

@smichr

This comment has been minimized.

Copy link
Member

smichr commented Dec 23, 2014

OK, thanks! It's in.

smichr added a commit that referenced this pull request Dec 23, 2014

Merge pull request #8647 from aktech/master
Fix sign Error in Unrad Function issue #8622

@smichr smichr merged commit 747f8d5 into sympy:master Dec 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@aktech

This comment has been minimized.

Copy link
Member Author

aktech commented Dec 23, 2014

@smichr
Thanks, that's my first! :)

@aktech aktech referenced this pull request Jun 19, 2015

Closed

This Closes #8622 #8625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment