Skip to content

Conversation

@kendhia
Copy link
Contributor

@kendhia kendhia commented Dec 29, 2011

I make an XFAIL test for issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to add a blank line at the end of the file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use == not =. It is not clear why the inverse of a function would give you an order term. I'm sorry the issue is not more clear. I think they made a similar confusion there. I'm not sure this is worth adding as an XFAIL.

Notice also what the next line says.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use I and pi. And make sure that they are imported at the top of the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the wrong file anyway, but why did you import raises?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import S.

@asmeurer
Copy link
Member

You need to strip trailing whitespace. Use ./bin/test quality to see the problems, and ./bin/strip_whitespace <file> to fix them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has trailing whitespace.

@asmeurer
Copy link
Member

SymPy Bot Summary: All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn4QJDA

Interpreter: /sw/bin/python (2.5.0-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: 8eb40ab
branch hash: db0b7b2

Automatic review by SymPy Bot.

@asmeurer
Copy link
Member

SymPy Bot Summary: There were test failures.

@kendhia: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYuvwIDA

Interpreter: /sw/bin/python (3.2.2-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: 8eb40ab
branch hash: db0b7b2

Automatic review by SymPy Bot.

@asmeurer
Copy link
Member

OK, I think this is good to go.

asmeurer added a commit that referenced this pull request Dec 31, 2011
[GCI} XFAIL test for issues .
@asmeurer asmeurer merged commit 94e31d7 into sympy:master Dec 31, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants