Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCI} XFAIL test for issues . #905

Merged
merged 44 commits into from Dec 31, 2011
Merged

[GCI} XFAIL test for issues . #905

merged 44 commits into from Dec 31, 2011

Conversation

kendhia
Copy link
Contributor

@kendhia kendhia commented Dec 29, 2011

I make an XFAIL test for issues

@XFAIL
def test_issue_1724():
a = S("(-29/54 + 93**(1/2)/18)**(1/3)")
a.conjugate().evalf() == a.evalf().conjugate()
Copy link
Member

@smichr smichr Dec 29, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to add a blank line at the end of the file

x = Symbol('x')
f = Function('f')
g = Function('g')
assert 1/g(x) = O(1/f(x))
Copy link
Member

@smichr smichr Dec 29, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use == not =. It is not clear why the inverse of a function would give you an order term. I'm sorry the issue is not more clear. I think they made a similar confusion there. I'm not sure this is worth adding as an XFAIL.

Notice also what the next line says.

@@ -273,3 +273,6 @@ def tn(a, b):
assert principal_branch(x, -4).func is principal_branch
assert principal_branch(x, -oo).func is principal_branch
assert principal_branch(x, zoo).func is principal_branch
@XFAIL
def test_issue_2453():
assert abs(sympy.I * sympy.pi) == pi
Copy link
Member

@asmeurer asmeurer Dec 29, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use I and pi. And make sure that they are imported at the top of the file.

@@ -3,6 +3,8 @@

from random import randint, choice, seed

from sympy.utilities.pytest import XFAIL, raises
Copy link
Member

@asmeurer asmeurer Dec 29, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the wrong file anyway, but why did you import raises?


@XFAIL
def test_issue_1724():
a = S("(-29/54 + 93**(1/2)/18)**(1/3)")
Copy link
Member

@asmeurer asmeurer Dec 30, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import S.

@asmeurer
Copy link
Member

asmeurer commented Dec 30, 2011

You need to strip trailing whitespace. Use ./bin/test quality to see the problems, and ./bin/strip_whitespace <file> to fix them.

@@ -140,4 +142,4 @@ def test_mod():
def test_div_negative_rnd_bug():
mp.dps = 15
assert (-3) / mpf('0.1531879017645047') == mpf('-19.583791966887116')
assert mpf('-2.6342475750861301') / mpf('0.35126216427941814') == mpf('-7.4993775104985909')
assert mpf('-2.6342475750861301') / mpf('0.35126216427941814') == mpf('-7.4993775104985909')
Copy link
Member

@asmeurer asmeurer Dec 30, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has trailing whitespace.

@asmeurer
Copy link
Member

asmeurer commented Dec 31, 2011

SymPy Bot Summary: All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn4QJDA

Interpreter: /sw/bin/python (2.5.0-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: 8eb40ab
branch hash: db0b7b2

Automatic review by SymPy Bot.

@asmeurer
Copy link
Member

asmeurer commented Dec 31, 2011

SymPy Bot Summary: There were test failures.

@kendhia: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYuvwIDA

Interpreter: /sw/bin/python (3.2.2-final-0)
Architecture: Darwin (64-bit)
Cache: yes
Test command: setup.py test
master hash: 8eb40ab
branch hash: db0b7b2

Automatic review by SymPy Bot.

@asmeurer
Copy link
Member

asmeurer commented Dec 31, 2011

OK, I think this is good to go.

asmeurer added a commit that referenced this issue Dec 31, 2011
[GCI} XFAIL test for issues .
@asmeurer asmeurer merged commit 94e31d7 into sympy:master Dec 31, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants