-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[GCI} XFAIL test for issues . #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sympy/core/tests/test_evalf.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to add a blank line at the end of the file
sympy/mpmath/tests/test_division.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to use == not =. It is not clear why the inverse of a function would give you an order term. I'm sorry the issue is not more clear. I think they made a similar confusion there. I'm not sure this is worth adding as an XFAIL.
Notice also what the next line says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use I and pi. And make sure that they are imported at the top of the file.
sympy/mpmath/tests/test_division.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the wrong file anyway, but why did you import raises?
sympy/core/tests/test_complex.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to import S.
|
You need to strip trailing whitespace. Use |
sympy/mpmath/tests/test_division.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has trailing whitespace.
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn4QJDA Interpreter: /sw/bin/python (2.5.0-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: There were test failures. @kendhia: Please fix the test failures. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYuvwIDA Interpreter: /sw/bin/python (3.2.2-final-0) Automatic review by SymPy Bot. |
|
OK, I think this is good to go. |
[GCI} XFAIL test for issues .
I make an XFAIL test for issues