Skip to content
This repository

Gruntz examples #977

Merged
merged 6 commits into from almost 2 years ago

7 participants

raoulb Christopher Smith Tom Bachmann Vladimir Perić Aaron Meurer Stefan Krastanov Ondřej Čertík
raoulb
Collaborator
  • Examples from Gruntz' thesis as ipython notebook
  • Removed duplicated 'gruntz(...)' tests
Christopher Smith
Collaborator

I have no experience with the notebook format...perhaps someone else can handle this.

Tom Bachmann
Collaborator

For reference (since I managed to get the notebook to work :D), the example file looks like this when rendered:

http://ifile.it/w6g7f8s/gruntz.pdf

raoulb
Collaborator

Hmm, seems you don't have mathjax working.

Vladimir Perić

I think the general "consensus" was to put the notebooks in examples/notebooks (ie. not to use the currentl begginer/intermediate/advanced directory structure), but maybe something else was decided while I wasn't looking. What is the status of this, anyway? I thought we already had some notebooks as part of GCI, but I don't see them anywhere. @asmeurer?

EDIT: Other than that, I've no idea on this; I haven't yet taken the time to get notebooks to work, though I intend to do so. :)

raoulb
Collaborator

Right, I'll move the notebook files.

raoulb
Collaborator

Should be ready now.

Aaron Meurer
Owner

We never added them. I think there was only one that was good enough to include. It should still be on melange.

Aaron Meurer
Owner

Let's put notebooks in the normal structure (beginning, intermediate, advanced), so we don't have to sort through them when we convert everything to notebooks.

Stefan Krastanov
Collaborator

Can this go in? There was discussion about using notebook format version 2 instead of 3. Is this still an issue?

Aaron Meurer
Owner
Stefan Krastanov
Collaborator
Stefan Krastanov
Collaborator
Ondřej Čertík
Owner
certik commented

I am +1 to merge this. If there are no further objections, I'll merge it soon.

Stefan Krastanov
Collaborator

Ipython 0.13 was released last week so the issue with the version is not as burning as it was.
@certik gave a +1.
I am merging this in a few hours if there are no new issues. Are there any, @raoulb?

raoulb
Collaborator
raoulb commented

Are there any

I'm not aware of any open task on this PR.

Stefan Krastanov
Collaborator

merging...

Stefan Krastanov Krastanov merged commit 387547b into from
Stefan Krastanov Krastanov closed this
Christopher Smith
Collaborator
smichr commented
Christopher Smith
Collaborator
smichr commented

I wonder why this branch was never tested by the bot?

Stefan Krastanov
Collaborator

The automatic script that I was using does not check older pull requests (due to some unknown to me detail of the github api). I do not know why travis did not check it.

I suppose that I should have checked the whole discussion page, not only the last few comments. I am sorry, I will try to see where the error comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.