Conversation
- Remove deploy.py
- repo slug condition - condition for pull request - GAE secret extraction
Member
Author
|
Will merge within 24 hr, if no objections. @asmeurer Let me know if you have any questions and if anything is not clear in the instructions. |
Member
|
Is there any way to make it so GitHub shows the deployment on the pull request (GitHub has a feature where it can show deployments above the merge button, for example, like it does for the bot here) |
Member
Author
|
I think you mean this one? asmeurer/GitHub-Issues-Test#43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
gcloudCLI.deploy.pyand got rid of it.app.yaml.template. Now oneapp.yamlworks for any deployment..travis.yml.Deployment via Travis behaviour:
(This uses the Travis's inbuilt deploy support for GAE to simplify deployments: The PR builds skips the deployment altogether, we cannot have pull request number as the version number because the deployment can only happen in the branch push triggered builds.)
Deployed via branch push build: https://fix-deploy-dot-sympy-gamma-hrd.appspot.com