Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment to use Cloud SDK #137

Merged
merged 5 commits into from Apr 15, 2020
Merged

Fix deployment to use Cloud SDK #137

merged 5 commits into from Apr 15, 2020

Conversation

aktech
Copy link
Member

@aktech aktech commented Apr 14, 2020

Fixes #136

  • Fixes broken deployment process.
  • Uses gcloud CLI.
  • Uses service account for authentication, added the key for the same in travis environment variables and adds the encrypted key in the repo (Using a better way to store encrypted key is the one for later).
  • Removed dependency from deploy.py and got rid of it.
  • Removed app.yaml.template. Now one app.yaml works for any deployment.
  • Updated Readme instructions.
  • Tidying up .travis.yml.

Deployment via Travis behaviour:

  • Tagged release (promoted to main site)
  • Repo branch Pull Requests deployed to branch-name-dot-sympy-gamma-tests.appspot.com

(This uses the Travis's inbuilt deploy support for GAE to simplify deployments: The PR builds skips the deployment altogether, we cannot have pull request number as the version number because the deployment can only happen in the branch push triggered builds.)

Deployed via branch push build: https://fix-deploy-dot-sympy-gamma-hrd.appspot.com

aktech added 4 commits Apr 13, 2020
- repo slug condition
- condition for pull request
- GAE secret extraction
@aktech aktech requested a review from asmeurer Apr 14, 2020
@aktech
Copy link
Member Author

aktech commented Apr 14, 2020

Will merge within 24 hr, if no objections. @asmeurer Let me know if you have any questions and if anything is not clear in the instructions.

@asmeurer
Copy link
Member

Is there any way to make it so GitHub shows the deployment on the pull request (GitHub has a feature where it can show deployments above the merge button, for example, like it does for the bot here)

@aktech
Copy link
Member Author

aktech commented Apr 14, 2020

I think you mean this one? asmeurer/GitHub-Issues-Test#43
Surely, we can use the @sympy-bot to implement something like that, the way you have in the PR above.

@aktech aktech merged commit 62a7658 into master Apr 15, 2020
@aktech aktech deleted the fix-deploy branch Apr 15, 2020
@aktech aktech added the GAE-Python3 Everything related to upgrading to Google App engine's Python3 runtime label Apr 17, 2020
@aktech aktech added this to Done in GAE Python 3 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GAE-Python3 Everything related to upgrading to Google App engine's Python3 runtime
Projects
No open projects
GAE Python 3
  
Done
Development

Successfully merging this pull request may close these issues.

Deployment process is broken
2 participants