Migrate to Cloud NDB to prepare for Python3 upgrade #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is based on: https://cloud.google.com/appengine/docs/standard/python3/migrating-to-cloud-ndb - [x] Replaced Python 2 only NDB library with Cloud NDB `from google.cloud import ndb` - [x] Introduces `appengine_config.py` to include third party libraries, which are not supported by GAE natively. - [x] Includes `client_secret.json` in the App deployment to allow access to Datastore from app engine - [x] Got rid of `travis.py` and added instructions to run tests via simple commands - [x] Configured requests to use URLFetch See [this](https://cloud.google.com/appengine/docs/standard/python/issue-requests#requests) - [x] Added basic logging for debugging We have two requirements file at the moment: - `local_requirements.txt`: This is required for local development only, See [this](https://cloud.google.com/appengine/docs/standard/python/tools/using-libraries-python-27#local_development) - `requirements.txt`: This is installed in the `lib` folder for local as well as deployed environment. Changes from Google App engine console: - [x] Added the role `Cloud Datastore Owner` to the service account to be able to access Datastore from app engine App.
aktech
added
the
GAE-Python3
|
Will merge in 48 hours if no objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #139
This implementation is based on:
https://cloud.google.com/appengine/docs/standard/python3/migrating-to-cloud-ndb
from google.cloud import ndbappengine_config.pyto include third party libraries, which are not supported by GAE natively.client_secret.jsonin the App deployment to allow access to Datastore from app enginetravis.pyand added instructions to run tests via simple commandsWe have two requirements file at the moment:
local_requirements.txt: This is required for local development only, See thisrequirements.txt: This is installed in thelibfolder for local as well as deployed environment.Changes from Google App engine console:
Cloud Datastore Ownerto the service account to be able to access Datastore from app engine App.cc @asmeurer @certik