-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Python 3 runtime of Google App Engine #154
Conversation
So the submodules aren't needed anymore? |
Yes, they aren't needed anymore. We install everything via |
I see. IIRC we were pinned to some commit between versions. We should make sure 0.7.5 doesn't break anything. |
Yes, correct. I tried to break, but everything seems to work of what I tried: https://py3-runtime-dot-sympy-gamma-hrd.appspot.com/ |
I have tried all the possible cases I can think of and the tests passes as well. I'll merge this in next 48 hours if no objections. |
We can still do a quick revert in the deploy if this ends up breaking, right? |
Yup, quite easily. |
OK. I wasn't sure if switching the runtime had an effect on that. |
I would really thank you for this perfect work |
@WaleedSaleh It could be a caching issue, can you try doing a Hard refresh on your browser (you can Google for your browser on how to do that.). Also just to confirm, can you share the command you are using to run the app? |
@WaleedSaleh I see why you're seeing that error, you need to set Line 26 in 17b9f0e
I have created a PR for mentioning this in the README: #158 Thanks for pointing this out. |
You're welcome, I used docker-compose up for running the app because when using "python mange.py runserver" this error occurs:
|
@WaleedSaleh |
@aktech thank you, it worked with docker-compose up |
This migrates the application to Python3 runtime of Google App Engine.
.gcloudignore
Further cleanups will happen in later Pull requests.