Improve stability of node specs #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I fully understand what the benefit is from manually draining subscriptions one by one? When the NATS connection is closed, its subscriptions go away. If the server times out a client connection, that connection's subscriptions go away. Is there a scenario or a use case (or than a test) that explicit subscription draining addresses? |
kthomas
force-pushed
the
fix/sub-draining
branch
from
3da0e7f
to
be1a988
Compare
kthomas
force-pushed
the
fix/sub-draining
branch
from
be1a988
to
5899077
Compare
autodidaddict
approved these changes
Jun 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures all subscriptions are drained before exiting.
Also,
node.Stop()was a method added solely for use by the spec suite. It has been removed in favor of using signals. This should dramatically increase stability of the spec suite.